Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added logic to show an error page/msg if email cannot be sent as repo… #44

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

zhangguiyu
Copy link

Dear Mr. Bruno Renié,

Thank you for creating a fantastic password reset module, with such a clean and elegant and modular design!

For this pull request, I have made the following contributions:

  1. Added Logic and corresponding templates/urls to handle situations where email delivery fails (current version will result in a 500 server error) due to invalid email associated with a registered Django user,
  2. Added optional captcha in the password reset page using django-simple-captcha==0.5.1 if the latter is installed. I have not enabled this dependency in setup.py, so that this remains optional. I have also updated the test cases and quick install doc page to reflect this optional capability. We use this captcha together with django-axis (not required) to discourage bots from attacking the site with brute force trial-and-error of email addresses or usernames,
  3. Updated and refined existing Chinese translations. I have also added some new sentences associated with the failed email delivery notification page/template. The new Chinese translations are stored under the zh-hans directory, with a symbolic link zh_Hans (for Django to find it), in accordance with the latest Django language definition for Chinese,
  4. Updated all test cases to work with the optional captcha, even in the situation when captcha is actually installed in pythonenv but not listed in settings.INSTALLED_APPS. All tests have passed.
  5. Re-formatted the two lambda (F, get_user) functions into normal def functions in order to comply with Travis Lint. Fixed various errors reported by Lint, so that the final build now passes 100% of the Travis Tests.

Please review them, and include whatever you think is suitable.

Thank you again for your great work!

Yours Truly,
Julian Kuiyu CHANG

@zhangguiyu
Copy link
Author

you wanna review this merge? I can help test/merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants